fix: populate env.json with valid Kafka bootstrap addresses#188
fix: populate env.json with valid Kafka bootstrap addresses#188asyncapi-bot merged 3 commits intoasyncapi:masterfrom
Conversation
The generator was putting the "kafka-secure://" protocol prefix in the bootstrap address for generated Kafka apps, which the Kafka client library rejects as an invalid URL. This commit uses the hostname if it is available (v3 docs) but falls back to using the url otherwise (v2 docs). Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
dalelane
requested review from
AGurlhosur,
JEFFLUFC,
KieranM1999,
asyncapi-bot-eve,
dan-r and
lewis-relph
as code owners
|
/rtm |
|
Hello, @dalelane! 👋🏼 |
|
/rtm /au |
|
Hello, @dalelane! 👋🏼 |
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
|
/rtm |
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
The generator was putting the "kafka-secure://" protocol prefix in the bootstrap address for generated Kafka apps, which the Kafka client library rejects as an invalid URL.
This commit uses the hostname if it is available (v3 docs) but falls back to using the url otherwise (v2 docs).